mention-bot

Dev tools

code review bot

SHOW HN2015

mention-bot

Bot that mentions potential reviewers on pull requests

github.com

#pull request#code review#github bot#reviewer suggestion

72points
13comments
#376of 2,565 in 2015
Top 15%of 2015 by points

How HN took it

MixedNo clear lean

2 positive, 4 neutral or asking, 1 mixed, 2 critical, out of 9 comments about the project. Thread score +0.12.

Idea: 2 for, 0 against

The thread, comment by comment

Each row is a top-level comment and its replies, in HN's order. Select a cell to open that comment on HN.

positive neutral or mixed critical about another commenter or something else the maker

What HN said

What people liked

  • Good idea, blame-based reviewer suggestion is useful

    From 2 comments
    • I've always loved this idea. Fun fact: a blame-based suggested reviewers UI was included in the original Pull Request design mockups. We shipped with a much weaker list of…
      rtomayko on HN
    • Neat idea! I'm not on any large repos, but I can see how this would be useful.
      irremediable on HN

Objections

  • Patent grant language raises licensing concerns

    From 3 comments
    • How (or why) is Facebook claiming this is (or will be) patented? https://github.com/facebook/mention-bot/blob/master/PATENTS
      Amorymeltzer on HN
    • Thanks, that's helpful. It still strikes me as presumptuous to "grant" a patent license to non-patentable and un-patented material, but I suppose it makes sense from a…
      Amorymeltzer on HN
    • Where would I have to ask to get legally binding information on the specific patents for this bot? I am definitely not going to use its source (due to licensing issues with…
      kuschku on HN
  • Blame-based suggestions can pick the same overloaded person

    From 1 comment
    • Crucible essentially does this as well, when you create a review it will suggest reviewers based on commit history to the file. Sometimes handy, sometimes the bane of my…
      jaredmcateer on HN

Questions

  • Does Facebook hold patents covering this idea?

    From 2 comments
    • How (or why) is Facebook claiming this is (or will be) patented? https://github.com/facebook/mention-bot/blob/master/PATENTS
      Amorymeltzer on HN
    • Where would I have to ask to get legally binding information on the specific patents for this bot? I am definitely not going to use its source (due to licensing issues with…
      kuschku on HN

Alternatives named

  • Crucible suggests reviewers from commit history

    From 1 comment
    • Crucible essentially does this as well, when you create a review it will suggest reviewers based on commit history to the file. Sometimes handy, sometimes the bane of my…
      jaredmcateer on HN
  • get_maintainer.pl with MAINTAINERS file

    From 1 comment
    • so it's basically get_maintainer.pl sans usable MAINTAINERS file?
      Hello71 on HN

Category, keywords, summaries and labels on this page were made by AI (Thread Reader v2) and not checked by hand. Each point links to the comments it came from.

Add a badge to your READMEShown on HackerShow
[![Shown on HackerShow](https://hackershow.org/badge.svg)](https://hackershow.org/show/10596241)