PatchBin.com

Dev tools

code review

SHOW HN2010

45points
13comments
#39of 370 in 2010
Top 11%of 2010 by points

How HN took it

MixedNo clear lean

2 positive, 2 neutral or asking, 1 mixed, 4 critical, out of 9 comments about the project. Thread score -0.11.

Execution: 1 for, 2 againstPrivacy: 0 for, 1 againstDesign: 0 for, 1 againstIdea: 1 for, 0 against

The thread, comment by comment

Each row is a top-level comment and its replies, in HN's order. Select a cell to open that comment on HN.

positive neutral or mixed critical about another commenter or something else the maker

What HN said

What people liked

  • Clean, simple implementation

    From 1 comment
    • I really like this implementation. Very clean, effective, and simple. I hope you continue to make progress on it ^_^.
      thegoleffect on HN
  • Useful for remote code review

    From 1 comment
    • $(window).width() will display the viewable width of the client in jQuery. and onResize will fire on <body> when the window is resized. (food for thought) I think this is a…
      dimarco on HN

Objections

  • Security: XSS vulnerability reported, maker disabled escaping and is fixing it

    From 2 comments
    • XSS open. http://github.com/ninjagod/patchbin/issues#issue/1
      oinopion on HN
    • I disabled escaping because it had trouble rendering XML code. I thought it was safe but I was wrong. Fixing now. Thanks! [edit] fixed
      antileet on HN
  • Diff view too narrow for code, should allow 80+ characters

    From 2 comments
    • I know horizontal space is tight, but it'd be nice if you could have 2 at-least-80-character-wide views (rather than hard-wrapping them at whatever they are now) when you have a…
      mcav on HN
    • Agreed. 80 characters is the bare minimum for code viewing. The choice of 55, which this seems to be, is extremely odd considering it's designed to view diffs (which technically…
      thwarted on HN
  • Django running in DEBUG mode

    From 1 comment
  • No spam protection; comments lack logins or moderation

    From 1 comment
    • When creating a comment, don't pop up multiple comment entry boxes. Will you have logins and moderation etc to avoid spam?
      jestar_jokin on HN

Requests

  • Wider 80-character views on large screens

    From 2 comments
    • I know horizontal space is tight, but it'd be nice if you could have 2 at-least-80-character-wide views (rather than hard-wrapping them at whatever they are now) when you have a…
      mcav on HN
    • Thanks! I'm having a tough time with CSS right now. I hope to add a client-side way to detect when the screen is large enough and show 80 character wide views.
      antileet on HN
  • Cancel button on comment form

    From 1 comment
    • You might want to put a "cancel" button on the comment form. The blank comments might be people who are trying to get rid of the comment form after accidentally double-clicking.
      bloonlabs on HN
  • Logins and moderation to prevent spam

    From 1 comment
    • When creating a comment, don't pop up multiple comment entry boxes. Will you have logins and moderation etc to avoid spam?
      jestar_jokin on HN

Questions

  • Why are comments being saved blank?

    From 1 comment
    • To the folks who tried out the commenting: A lot of comments are blank. If you entered valid text and that didn't get written to the database, and is a bug. Can you please…
      antileet on HN

Category, keywords, summaries and labels on this page were made by AI (Thread Reader v2) and not checked by hand. Each point links to the comments it came from.

Add a badge to your READMEShown on HackerShow
[![Shown on HackerShow](https://hackershow.org/badge.svg)](https://hackershow.org/show/1108016)