Mako

This looks like a herculean effort over just the past few months. Congratulations on hitting this milestone and hopefully you can take a breather and tie up loose ends at a more…

Call me old school, but I like looking at the number of lines of code to get a feel for how big of a project something is. Mako[1] is 265,618 lines of code. The most widely…

I’m loving the well commented and standalone inplementations of crypto-primatives, will definitely be studying these. One question, in src/crypto/rand.c:25 you have a standalone…

Cloned and built on my Mac without any issues. Everything compiled and linked without warnings. A huge plus in my opinion. Other than stating that it builds two executables,…

This looks super interesting. One thing that kinda bothers me is that most of the tests are just #include <stdint.h> #include <stdlib.h> #include <string.h> #include…

Yeah, I'm embarrassed about that. It's way behind on tests. The past 2 months of limited sleep were a massive scramble just trying to get everything implemented and trying to get…

Cool to study. Disappointed there are zero comments and the most terse variable names as possible. Almost like it was js-minified.

This is a bad convention. Instead of `x` and `z`, you should describe what those pointers are meant to represent. I get that everything is subjective, but some things are…

Your english language description of it gives some good clues to the alternative: ``` int btc_tx_import(btc_tx_t *transaction, const uint8_t *raw_transaction, size_t…

Cloned and built on my Mac without any issues. Everything compiled and linked without warnings. A huge plus in my opinion. Other than stating that it builds two executables,…

Still experimental and documentation is lacking, but right now the CLI behavior is almost identical to `bitcoind` and `bitcoin-cli`. So, for example, `$ makod -datadir=foobar…

This is very impressive, but I’ll be honest, I wouldn’t want to expose any new software written in C to the internet.

Not to belittle the work, but it is always prudent to research what the other implementations are before possibly doing duplicate work and providing that comparison along with…

Cloned and built on my Mac without any issues. Everything compiled and linked without warnings. A huge plus in my opinion. Other than stating that it builds two executables,…

This is a bad convention. Instead of `x` and `z`, you should describe what those pointers are meant to represent. I get that everything is subjective, but some things are…

Your english language description of it gives some good clues to the alternative: ``` int btc_tx_import(btc_tx_t *transaction, const uint8_t *raw_transaction, size_t…

I've been writing C for two decades. But in recent years I have used Go as a replacement for C whenever possible. I think of Go as an improved C, with slightly different…

can something like this actually participate in the real bitcoin network or does everyone have to run the same client?

This look cool! great job, congrats. What are you using as data storage? I understand btcd uses leveldb, are you using something similar?

Call me old school, but I like looking at the number of lines of code to get a feel for how big of a project something is. Mako[1] is 265,618 lines of code. The most widely…

This look cool! great job, congrats. What are you using as data storage? I understand btcd uses leveldb, are you using something similar?

Not to belittle the work, but it is always prudent to research what the other implementations are before possibly doing duplicate work and providing that comparison along with…

Right. Perhaps I should explain this in the readme. To be clear: Libbtc is a small bitcoin library meant for everyday things: signing transactions, maintaining an SPV wallet,…

My first bitcoin reimplementation was written in node.js and called bcoin[1]. So this is my second time reimplementing the bitcoin protocol, albeit in a very different language.…